GrafX2 version 2.8.3108

All about the serious stuff.

Moderators: Mug UK, Zorro 2, Moderator Team

marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

GrafX2 version 2.8.3108

Post by marss »

New version of the 256 color painting program for Mint released in early October ;)
Thing is the cursor moves very slowly whereas Mono's version 2.4 works perfectly.
Any solution?
http://grafx2.gitlab.io/grafX2/
Thanks
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

new version released with the same problems;(
Help!!! ;)
m0n0
Captain Atari
Captain Atari
Posts: 439
Joined: Mon Oct 05, 2009 3:13 am

Re: GrafX2 version 2.8.3108

Post by m0n0 »

Hello,

I once submitted a patch to SDL Library developer (atari specific version) to adress such an issue. AFAIK the patch was integrated into the Library. The patch solved some problem on how the lib handles/polls GEM events, when I remeber correctly. I will have a look into the version comments.
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

Thanks for the reply.
mikro
Hardware Guru
Hardware Guru
Posts: 3539
Joined: Sat Sep 10, 2005 11:11 am
Location: Kosice, Slovakia
Contact:

Re: GrafX2 version 2.8.3108

Post by mikro »

What a rabbit hole I fell into... your complain reminded me of a years old bug reports for my other projects which I thought had been fixed: ScummVM and OpenTTD. These fixes were based on Olivier Landemarre's code back then: https://github.com/mikrosk/SDL-1.2/commits/olivier

From what I could remember, Patrice Mandin (Atari SDL maintainer) told me that Olivier's patches were incorporated into his tree but not in such exact form but the functionality should be there.

So to verify this claim I compiled zlib, libpng, SDL_image, SDL and finally Grafx2. And what? And it indeed works much better. So my conclusion is that Grafx2's developer simply uses some outdated version of libSDL.

In the meantime I've been maintaining my fork of libSDL 1.2 here: https://github.com/mikrosk/SDL-1.2 ... it contains all fixes used for my Atari800 and works very well. You can tell Grafx2's developer to pull that version.

As a bonus, he wont need to apply that strange SDL patch in his source tree (replacing VBL interrupts for something ... else) and the binary wont crash with Aranym+MMU as currently does.

Not sure about m0n0's patch though. If Patrice got it, most likely it is in my source tree already.

And since I went through all of this and it would be a shame to waste it for nothing, here you are, binaries for both 020+ and FireBee. Please note that I was lazy to compile-in support for TIFFs, JPEGs, TTFs and LUA.
You do not have the required permissions to view the files attached to this post.
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

Thanks a lot. It is working great now. Every time I quit the app, a message shows that the Grafx2.ini is corrupted and to remove it so that the app could create a new one. But even doing so, the same message reappears.
May you find the force to recompile support for TIFFs, JPEGs, TTFs and LUA ;)
mikro
Hardware Guru
Hardware Guru
Posts: 3539
Joined: Sat Sep 10, 2005 11:11 am
Location: Kosice, Slovakia
Contact:

Re: GrafX2 version 2.8.3108

Post by mikro »

I guess you are doing this in TOS? I didn't see such message with FreeMiNT. Quick look into source code tells me that it fails on fgets() call, which is supposed to read one line of text from file. My guess would be that this is somehow CR/LF related.
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

Under Freemint/ Myaes 0.98 patch 4 (30th December)+Radeon+CosmosEX3
You do not have the required permissions to view the files attached to this post.
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

mikro
Hardware Guru
Hardware Guru
Posts: 3539
Joined: Sat Sep 10, 2005 11:11 am
Location: Kosice, Slovakia
Contact:

Re: GrafX2 version 2.8.3108

Post by mikro »

Has the author fixed the issues? (assuming you had reported them :)
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

No. Still the same problems ;(
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

mikro
Hardware Guru
Hardware Guru
Posts: 3539
Joined: Sat Sep 10, 2005 11:11 am
Location: Kosice, Slovakia
Contact:

Re: GrafX2 version 2.8.3108

Post by mikro »

And did you report the problems?
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

How to explain it technically?
Maybe you Can Do your Magic tricks to make it work?😁
mikro
Hardware Guru
Hardware Guru
Posts: 3539
Joined: Sat Sep 10, 2005 11:11 am
Location: Kosice, Slovakia
Contact:

Re: GrafX2 version 2.8.3108

Post by mikro »

marss wrote: Thu Feb 03, 2022 7:35 am How to explain it technically?
Maybe you Can Do your Magic tricks to make it work?😁
As mentioned:
mikro wrote: Sat Jan 01, 2022 11:28 pmIn the meantime I've been maintaining my fork of libSDL 1.2 here: https://github.com/mikrosk/SDL-1.2 ... it contains all fixes used for my Atari800 and works very well. You can tell Grafx2's developer to pull that version.

As a bonus, he wont need to apply that strange SDL patch in his source tree (replacing VBL interrupts for something ... else) and the binary wont crash with Aranym+MMU as currently does.
... just tell him to use my SDL source code on github. Or point him to this thread.
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

Will do😁
User avatar
nanard
Captain Atari
Captain Atari
Posts: 179
Joined: Mon Apr 04, 2016 2:11 pm

Re: GrafX2 version 2.8.3108

Post by nanard »

@mikro I have to extract the patch from your repository for use on the official SDL-1.2.15 sources tarball.
At the moment I'm using only this patch
https://gitlab.com/GrafX2/grafX2/-/blob ... imer.patch
which I dont remember where I got it ;)
4MB STE + CosmosEx /|\ MegaST4 + MegaFile 44 /|\ Stacy 4
User avatar
nanard
Captain Atari
Captain Atari
Posts: 179
Joined: Mon Apr 04, 2016 2:11 pm

Re: GrafX2 version 2.8.3108

Post by nanard »

I think I initially started from http://vincent.riviere.free.fr/soft/m68k-atari-mint/

Maybe I should just diff your sources with SDL-1.2.15 and make a patch out of that ;)
4MB STE + CosmosEx /|\ MegaST4 + MegaFile 44 /|\ Stacy 4
mikro
Hardware Guru
Hardware Guru
Posts: 3539
Joined: Sat Sep 10, 2005 11:11 am
Location: Kosice, Slovakia
Contact:

Re: GrafX2 version 2.8.3108

Post by mikro »

nanard wrote: Mon Feb 07, 2022 8:53 am @mikro I have to extract the patch from your repository for use on the official SDL-1.2.15 sources tarball.
At the moment I'm using only this patch
https://gitlab.com/GrafX2/grafX2/-/blob ... imer.patch
which I dont remember where I got it ;)
Sorry, I don't understand. Don't extract anything from anywhere, just use my SDL tree and don't patch anything if you want to get the same (working/fast) build. :)
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

updated... https://gitlab.com/GrafX2/grafX2/-/jobs ... i-mint.zip
but still the same problem: slow cursor ;(
User avatar
Eero Tamminen
Fuji Shaped Bastard
Fuji Shaped Bastard
Posts: 3385
Joined: Sun Jul 31, 2011 1:11 pm

Re: GrafX2 version 2.8.3108

Post by Eero Tamminen »

I tried the latest build in Hatari + EmuTOS v1.2.1. Mouse cursor is not just slow, it leaves garbage behind it, whereas @mikro's build works fine.

Application crashes at startup on TT:

Code: Select all

Unable to change video mode!
WARN : Bus Error reading at address $4, PC=$27104c addr_e3=27104c op_e3=2028
GEMDOS 0x4C Pterm(-1) at PC 0xE0126E
I.e. it works only on Falcon (+ FPU), although this is supposed to be 256-color program?

As @mikro's build included debug symbols, I profiled idling in zoom view. Post-processing the profile data saved from Hatari debugger:

Code: Select all

$ gst2ascii -l -o -a -b -d  grafx2-020.gtp > grafx-2.sym
$ ignore_syms=ikbd_endit_stack,ikbd_yes_mouse,ikbd_mousex,ikbd_mousey,ikbd
$ hatari_profile.py -r grafx-2.sym -a etos1024k.sym -stp -g --compact --limit 0.25 --no-limited --emph-limit 2.5 --ignore $ignore_syms grafx.prof
$ dot -Tpng -Gsize=20 grafx-2.dot > grafx-2.png
Gave:
grafx-2.png
=> Print_general() function is taking surprising amount of CPU. Depending on whether program is actually waiting or not, SDL_Delay() amount could also be worrying.

(To view actual details, post-process profile data without "--no-limited" option, and view resulting *.dot files with "xdot".)
You do not have the required permissions to view the files attached to this post.
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

Updated... http://grafx2.gitlab.io/grafX2/
and still the same slow cursor ;(
User avatar
nanard
Captain Atari
Captain Atari
Posts: 179
Joined: Mon Apr 04, 2016 2:11 pm

Re: GrafX2 version 2.8.3108

Post by nanard »

mikro wrote: Mon Feb 07, 2022 12:13 pm
nanard wrote: Mon Feb 07, 2022 8:53 am @mikro I have to extract the patch from your repository for use on the official SDL-1.2.15 sources tarball.
At the moment I'm using only this patch
https://gitlab.com/GrafX2/grafX2/-/blob ... imer.patch
which I dont remember where I got it ;)
Sorry, I don't understand. Don't extract anything from anywhere, just use my SDL tree and don't patch anything if you want to get the same (working/fast) build. :)
It is an automated build, so it does use sources from https://www.libsdl.org/release/ which are SIGNED and patches them with specific patches.
Unless there is a signed sources for your SDL tree, we won't create a security issue in the build process by using it without verification.
4MB STE + CosmosEx /|\ MegaST4 + MegaFile 44 /|\ Stacy 4
User avatar
nanard
Captain Atari
Captain Atari
Posts: 179
Joined: Mon Apr 04, 2016 2:11 pm

Re: GrafX2 version 2.8.3108

Post by nanard »

marss wrote: Tue Feb 14, 2023 12:13 pm Updated... http://grafx2.gitlab.io/grafX2/
and still the same slow cursor ;(
It is an automated build, so it is updated for every new commit.
4MB STE + CosmosEx /|\ MegaST4 + MegaFile 44 /|\ Stacy 4
marss
Captain Atari
Captain Atari
Posts: 367
Joined: Thu Nov 07, 2002 12:29 pm

Re: GrafX2 version 2.8.3108

Post by marss »

What a pity 😩
Post Reply

Return to “Applications”