This is exactly what it's supposed to do! Both scanlines and the LCD effect are correct with my original coefficients for both VIP and ASCAL.Sorgelig wrote:I think LCD and scanlines filters should be updated to have darker parts on the edges instead of middle. This will outline original pixels and will have better outlook.
I think we must not be getting the same results on our screens!
For me, I always get the correct results with coefficients that I produce. But somehow you must get different results. And that's why we disagree about the correct coefficients.
Please tell me if you get these results. The top row is VIP and ASCAL from your release today with full/vip and lite/ascal with MY lcd coefficients. The bottom is with your modified coefficients that you posted Nov 15 above. Both are at 1920x1080 on a 1920x1080 TV. Sorry for some blur, but you can still see that I get correct results only with my original coefficient set. This is just the opening screen from 240P test suite.
I used your release from today for the full version and I compiled the lite version myself. I erased Genesis stuff from my config folder just in case that made a difference.
To be perfectly clear. The top two pictures used this coefficient set:
Code: Select all
# range -128..128
# sum of line must not exceed the range!
# Even Sharper Bilinear with pixel outline
# effect (for LCD simulation)
# horizontal coefficients
0, 128, 0, 0
0, 128, 0, 0
0, 127, 0, 0
0, 125, 0, 0
0, 120, 2, 0
0, 110, 6, 0
0, 95, 13, 0
0, 76, 26, 0
0, 50, 50, 0
0, 26, 76, 0
0, 13, 95, 0
0, 6, 110, 0
0, 2, 120, 0
0, 0, 125, 0
0, 0, 127, 0
0, 0, 128, 0
# vertical coefficients
0, 128, 0, 0
0, 128, 0, 0
0, 127, 0, 0
0, 125, 0, 0
0, 120, 2, 0
0, 110, 6, 0
0, 95, 13, 0
0, 76, 26, 0
0, 50, 50, 0
0, 26, 76, 0
0, 13, 95, 0
0, 6, 110, 0
0, 2, 120, 0
0, 0, 125, 0
0, 0, 127, 0
0, 0, 128, 0
Code: Select all
# range -128..128
# sum of line must not exceed the range!
# Sorgelig Modified LCD
# horizontal coefficients
0, 128, 0, 0
0, 128, 0, 0
0, 127, 0, 0
0, 125, 0, 0
0, 122, 0, 0
0, 116, 0, 0
0, 108, 0, 0
0, 102, 0, 0
0, 100, 0, 0
0, 102, 0, 0
0, 108, 0, 0
0, 116, 0, 0
0, 122, 0, 0
0, 125, 0, 0
0, 127, 0, 0
0, 128, 0, 0
# vertical coefficients
0, 128, 0, 0
0, 128, 0, 0
0, 127, 0, 0
0, 125, 0, 0
0, 122, 0, 0
0, 116, 0, 0
0, 108, 0, 0
0, 102, 0, 0
0, 100, 0, 0
0, 102, 0, 0
0, 108, 0, 0
0, 116, 0, 0
0, 122, 0, 0
0, 125, 0, 0
0, 127, 0, 0
0, 128, 0, 0